1
0
mirror of https://github.com/actions/checkout.git synced 2026-07-08 19:03:47 +08:00

Compare commits

...

4 Commits

Author SHA1 Message Date
CommanderRoot
cba42e5f17 Merge 55ad59dfaa into 0c366fd6a8 2026-02-20 08:48:18 -08:00
eric sciple
0c366fd6a8 Update changelog (#2357) 2026-01-09 14:09:42 -06:00
CommanderRoot
55ad59dfaa Merge branch 'main' into rm-deprecated-substr 2023-08-26 21:33:44 +02:00
Tobias Speicher
dedef103f1 Replace deprecated String.prototype.substr()
String.prototype.substr() is deprecated (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr) so we replace it with slice() which works similarily but isn't deprecated.
Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
2022-03-13 22:03:37 +01:00
5 changed files with 17 additions and 11 deletions

View File

@@ -1,5 +1,11 @@
# Changelog # Changelog
## v6.0.2
* Fix tag handling: preserve annotations and explicit fetch-tags by @ericsciple in https://github.com/actions/checkout/pull/2356
## v6.0.1
* Add worktree support for persist-credentials includeIf by @ericsciple in https://github.com/actions/checkout/pull/2327
## v6.0.0 ## v6.0.0
* Persist creds to a separate file by @ericsciple in https://github.com/actions/checkout/pull/2286 * Persist creds to a separate file by @ericsciple in https://github.com/actions/checkout/pull/2286
* Update README to include Node.js 24 support details and requirements by @salmanmkc in https://github.com/actions/checkout/pull/2248 * Update README to include Node.js 24 support details and requirements by @salmanmkc in https://github.com/actions/checkout/pull/2248

View File

@@ -336,7 +336,7 @@ class GitCommandManager {
line = line.trim() line = line.trim()
if (line.startsWith('ref:') || line.endsWith('HEAD')) { if (line.startsWith('ref:') || line.endsWith('HEAD')) {
return line return line
.substr('ref:'.length, line.length - 'ref:'.length - 'HEAD'.length) .slice('ref:'.length, line.length - 'HEAD'.length)
.trim() .trim()
} }
} }

View File

@@ -64,11 +64,11 @@ export async function prepareExistingDirectory(
if (ref) { if (ref) {
ref = ref.startsWith('refs/') ? ref : `refs/heads/${ref}` ref = ref.startsWith('refs/') ? ref : `refs/heads/${ref}`
if (ref.startsWith('refs/heads/')) { if (ref.startsWith('refs/heads/')) {
const upperName1 = ref.toUpperCase().substr('REFS/HEADS/'.length) const upperName1 = ref.toUpperCase().slice('REFS/HEADS/'.length)
const upperName1Slash = `${upperName1}/` const upperName1Slash = `${upperName1}/`
branches = await git.branchList(true) branches = await git.branchList(true)
for (const branch of branches) { for (const branch of branches) {
const upperName2 = branch.substr('origin/'.length).toUpperCase() const upperName2 = branch.slice('origin/'.length).toUpperCase()
const upperName2Slash = `${upperName2}/` const upperName2Slash = `${upperName2}/`
if ( if (
upperName1.startsWith(upperName2Slash) || upperName1.startsWith(upperName2Slash) ||

View File

@@ -43,7 +43,7 @@ function updateUsage(
const newReadme: string[] = [] const newReadme: string[] = []
// Append the beginning // Append the beginning
newReadme.push(originalReadme.substr(0, startTokenIndex + startToken.length)) newReadme.push(originalReadme.slice(0, startTokenIndex + startToken.length))
// Build the new usage section // Build the new usage section
newReadme.push('```yaml', `- uses: ${actionReference}`, ' with:') newReadme.push('```yaml', `- uses: ${actionReference}`, ' with:')
@@ -68,9 +68,9 @@ function updateUsage(
// Longer than width? Find a space to break apart // Longer than width? Find a space to break apart
let segment: string = description let segment: string = description
if (description.length > width) { if (description.length > width) {
segment = description.substr(0, width + 1) segment = description.slice(0, width + 1)
while (!segment.endsWith(' ') && !segment.endsWith('\n') && segment) { while (!segment.endsWith(' ') && !segment.endsWith('\n') && segment) {
segment = segment.substr(0, segment.length - 1) segment = segment.slice(0, -1)
} }
// Trimmed too much? // Trimmed too much?
@@ -84,14 +84,14 @@ function updateUsage(
// Check for newline // Check for newline
const newlineIndex = segment.indexOf('\n') const newlineIndex = segment.indexOf('\n')
if (newlineIndex >= 0) { if (newlineIndex >= 0) {
segment = segment.substr(0, newlineIndex + 1) segment = segment.slice(0, newlineIndex + 1)
} }
// Append segment // Append segment
newReadme.push(` # ${segment}`.trimRight()) newReadme.push(` # ${segment}`.trimRight())
// Remaining // Remaining
description = description.substr(segment.length) description = description.slice(segment.length)
} }
if (input.default !== undefined) { if (input.default !== undefined) {
@@ -113,7 +113,7 @@ function updateUsage(
newReadme.push('```') newReadme.push('```')
// Append the end // Append the end
newReadme.push(originalReadme.substr(endTokenIndex)) newReadme.push(originalReadme.slice(endTokenIndex))
// Write the new README // Write the new README
fs.writeFileSync(readmePath, newReadme.join(os.EOL)) fs.writeFileSync(readmePath, newReadme.join(os.EOL))

View File

@@ -304,6 +304,6 @@ function select(obj: any, path: string): any {
return obj[path] return obj[path]
} }
const key = path.substr(0, i) const key = path.slice(0, i)
return select(obj[key], path.substr(i + 1)) return select(obj[key], path.slice(i + 1))
} }